Comments on: Faster Swing Lists and Tables up to 88,000x

By: Jasper Potts

Jasper Potts — Fri, 29 Jan 2010 09:36:43 +0000

If it was a same or better performance for all conditions then I would have done. Problem is its really helps some use cases but slows others. So at least you can grab it here and try as a alternative if you are seeing performance issues. There might be a way to detect if the current use fits one implementation or another and auto switch, but I have not looked into it. Jasper

By: John Hendrikx

John Hendrikx — Fri, 29 Jan 2010 09:31:12 +0000

I had similar problems with the default ListSelectionModel. I found that it uses a BitSet implementation to keep track of selections, but BitSet does not have shift operations which are badly needed when items get removed or inserted into the underlying ListModel of the ListSelectionModel. The ListSelectionModel instead does a bit by bit shift of the data using many method calls.

I managed to improve this by creating a better BitSet class that provides shift functions. Although the improvements are nowhere near as good as what you achieved, it still was a factor 15 faster using the custom shift functions (which shifts a long at a time instead of a bit at a time). It might be worthwhile extending BitSet with these functions as they’re a lot faster than the alternative. It is a shame the internal representation is private or it would have been possible to do this as a subclass.

Anyway, please make the new model the default. It took me quite a while to track down what was causing the incredible slowdown when removing items that were selected (with a 50000 entry list, with 25000 entries selected, and removing 25000 items, it takes roughly 10 seconds to complete which is pretty insane ).

By: Dominique De Vito

Dominique De Vito — Thu, 03 Jan 2008 06:53:48 +0000

Outch, it is outstanding. Great job. Is there any chance to put your ideas into SwingLabs so that RangeListSelectionModel could be the default SelectionModel for JXTable ?
Thanks.

By: Anuradha

Anuradha — Wed, 28 Nov 2007 06:49:04 +0000

HI Jasper ,
Vary Nice ,But I found bug in RangeListSelectionModel class

I use JXTable and if I’m loading data to table and selecting first row (Only this happen if one of table column set to sorted before loading data )

(sorry about my English)

java.lang.ArrayIndexOutOfBoundsException: -1
at org.jdesktop.swingx.decorator.ShuttleSorter.mapTowardModel(ShuttleSorter.java:96)
at org.jdesktop.swingx.decorator.Filter.convertRowIndexToModel(Filter.java:115)
at org.jdesktop.swingx.decorator.FilterPipeline.convertRowIndexToModel(FilterPipeline.java:419)
at org.jdesktop.swingx.decorator.SelectionMapper.convertToModel(SelectionMapper.java:191)
at org.jdesktop.swingx.decorator.SelectionMapper.updateFromViewSelectionChanged(SelectionMapper.java:201)
at org.jdesktop.swingx.decorator.SelectionMapper$2.valueChanged(SelectionMapper.java:258)

in line 554

protected void fireValueChanged(int firstIndex, int lastIndex, boolean isAdjusting) {
ListSelectionEvent e = null;
for (ListSelectionListener listener : listSelectionListeners) {
if (e == null) {
e = new ListSelectionEvent(this, firstIndex, lastIndex, isAdjusting);
}
listener.valueChanged(e);
}
}